Re: [PATCH v2 3/6] arm64: dts: qcom: lemans-evk: fix SerDes PHY regulator supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:

Pre-existing issues:
- [High] Incomplete fix for SGMII SerDes PHY regulator supplies leaving dow=
nstream boards broken.
--

--- Patch [3]: [PATCH v2 3/6] arm64: dts: qcom: lemans-evk: fix SerDes PHY =
regulator supplies ---
commit 06c318320f4f12178e107aa08e3b5435de261d50
Author: Mohd Ayaan Anwar <[email protected]>

arm64: dts: qcom: lemans-evk: fix SerDes PHY regulator supplies

This commit fixes the SerDes PHY regulator supplies for the lemans-evk board
and its IFP mezzanine overlay. It replaces the incorrect phy-supply with
vdda-0p9-supply and vdda-1p2-supply.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dt=
s/qcom/lemans-evk.dts
> index 0c53640c42a65..5c046b9bfb3cd 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts

[ ... ]

> @@ -978,7 +978,8 @@ &sdhc {
>  };
> =20
>  &serdes0 {
> -	phy-supply =3D <&vreg_l5a>;
> +	vdda-0p9-supply =3D <&vreg_l4a>;
> +	vdda-1p2-supply =3D <&vreg_l1c>;

[Severity: High]
This isn't a bug introduced by this patch, but should this fix be applied to
other boards using this PHY?

It looks like several other device trees still define the deprecated
phy-supply property, such as in
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi:

&serdes0 {
	phy-supply =3D <&vreg_l5a>;
	status =3D "okay";
};

And similarly in arch/arm64/boot/dts/qcom/qcs8300-ride.dts,=20
arch/arm64/boot/dts/qcom/monaco-monza-som.dtsi, and=20
arch/arm64/boot/dts/qcom/monaco-evk.dts.

Booting these unmodified boards could result in the PHY driver either faili=
ng
to probe or falling back to dummy regulators and failing calibration, break=
ing
SGMII Ethernet connectivity.

Could the fix be extended to cover these other boards as well to ensure they
receive both required voltage supplies?

> =20
>  	status =3D "okay";
>  };

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804-b4-sgmiiet=
[email protected]?part=3D3