Re: [PATCH v2 4/6] arm64: dts: qcom: lemans-ride-common: fix SerDes PHY regulator supplies

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:

Pre-existing issues:
- [High] Incomplete refactoring: missing DT updates for new PHY regulator r=
equirements on Monaco and QCS8300 boards
--

--- Patch [4]: [PATCH v2 4/6] arm64: dts: qcom: lemans-ride-common: fix Ser=
Des PHY regulator supplies ---
commit defd43449ca452b489164f877878995171548517
Author: Mohd Ayaan Anwar <[email protected]>

arm64: dts: qcom: lemans-ride-common: fix SerDes PHY regulator supplies

This commit replaces the incorrect phy-supply property with the required
vdda-0p9-supply and vdda-1p2-supply properties for both SerDes PHY nodes in
the lemans-ride-common device tree.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi b/arch/arm6=
4/boot/dts/qcom/lemans-ride-common.dtsi
> index cefb8ff008063..923fd8736f31d 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> @@ -856,12 +856,16 @@ &qup_uart17_rx {
>  };
> =20
>  &serdes0 {
> -	phy-supply =3D <&vreg_l5a>;
> +	vdda-0p9-supply =3D <&vreg_l4a>;
> +	vdda-1p2-supply =3D <&vreg_l1c>;
> +

[Severity: High]
This is a pre-existing issue, but shouldn't other boards in the tree that
use the deprecated phy-supply for serdes0 also be updated?

For example, arch/arm64/boot/dts/qcom/monaco-evk.dts still uses:

&serdes0 {
	phy-supply =3D <&vreg_l4a>;

	status =3D "okay";
};

arch/arm64/boot/dts/qcom/monaco-monza-som.dtsi still uses:

&serdes0 {
	phy-supply =3D <&vreg_l5a>;

	status =3D "okay";
};

And arch/arm64/boot/dts/qcom/qcs8300-ride.dts still uses:

&serdes0 {
	phy-supply =3D <&vreg_l5a>;
	status =3D "okay";
};

Without these updates, will the driver fall back to dummy regulators and fa=
il
to place the required voltage and load votes for these boards? This might
result in PHY calibration timing out or Ethernet failing when shared rails
enter runtime PM suspend.

>  	status =3D "okay";
>  };
> =20
>  &serdes1 {
> -	phy-supply =3D <&vreg_l5a>;
> +	vdda-0p9-supply =3D <&vreg_l4a>;
> +	vdda-1p2-supply =3D <&vreg_l1c>;
> +
>  	status =3D "okay";
>  };

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804-b4-sgmiiet=
[email protected]?part=3D4