Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver

Changhuang Liang <[email protected]> Tue, 4 Aug 2026 01:09:46 +0000

Newsgroups	org.kernel.vger.linux-devicetree,org.infradead.lists.linux-riscv,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID	<ZQ4PR01MB12025A49B142D572311E5D6CF2D42@ZQ4PR01MB1202.CHNPR01.prod.partner.outlook.cn>

Hi, Uwe

Thanks for the review.

> Hello,
>=20
> On Sat, Aug 01, 2026 at 12:26:54AM -0700, Changhuang Liang wrote:
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/platform_device.h>
>=20
> Please don't include <linux/mod_devicetable.h>, which will go away soon.
> <linux/platform_device.h> already contains the necessary bits to have
> of_device_id defined, so you can just drop the #include for
> <linux/mod_devicetable.h>.
>=20
> This also affects several other patches in this series.

Will drop <linux/mod_devicetable.h> in v5.

Best Reagrds,
Changhuang