Re: [PATCH v7 4/7] ASoC: qcom: q6prm: add Audio IF clock IDs

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added clock macros use the misspelled prefix `LAPSS_` instead of the correct subsystem acronym `LPASS_` (Low Power Audio SubSystem), baking a typo into the Device Tree ABI and userspace sysfs.
--

--- Patch [4]: [PATCH v7 4/7] ASoC: qcom: q6prm: add Audio IF clock IDs ---
commit 92df360c5a0420b85998ac3f1d9ff28298be694a
Author: Prasad Kumpatla <[email protected]>

ASoC: qcom: q6prm: add Audio IF clock IDs

This commit adds the q6prm clock table entries and internal DSP clock IDs
for LPASS Audio IF backend clocks so machine drivers can request them
through the APM clock controller.

> diff --git a/sound/soc/qcom/qdsp6/q6prm-clocks.c b/sound/soc/qcom/qdsp6/q6prm-clocks.c
> index 02dad9ee98049..f613e2aee75e6 100644
> --- a/sound/soc/qcom/qdsp6/q6prm-clocks.c
> +++ b/sound/soc/qcom/qdsp6/q6prm-clocks.c
[ ... ]
> @@ -64,6 +64,34 @@ static const struct q6dsp_clk_init q6prm_clks[] = {
>  	Q6PRM_CLK(LPASS_CLK_ID_WSA2_CORE_TX_MCLK),
>  	Q6PRM_CLK(LPASS_CLK_ID_WSA2_CORE_TX_2X_MCLK),
>  	Q6PRM_CLK(LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK),
> +	Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF0_IBIT),

[Severity: Low]
This isn't a bug, but the prefix here is spelled LAPSS instead of LPASS
(Low Power Audio SubSystem). Since Q6PRM_CLK stringifies the ID to set
the clock's name, this typo will be exposed to userspace in sysfs and
debugfs, and it will become baked into the Device Tree ABI.

[ ... ]

> diff --git a/sound/soc/qcom/qdsp6/q6prm.h b/sound/soc/qcom/qdsp6/q6prm.h
> index 938b1bfce2873..cca77cd92bc17 100644
> --- a/sound/soc/qcom/qdsp6/q6prm.h
> +++ b/sound/soc/qcom/qdsp6/q6prm.h
[ ... ]
> @@ -97,6 +97,35 @@
>  /* Clock ID for RX CORE MCLK2 2X  MCLK */
>  #define Q6PRM_LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK 0x318
>  
> +#define Q6PRM_LAPSS_CLK_ID_QAIF_IF0_IBIT		0x500

[Severity: Low]
This isn't a bug, but similar to the above, these macros use the misspelled
LAPSS prefix instead of the established LPASS prefix.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4