Re: [PATCH v5 12/17] ARM: dts: microchip: sama7d65: Add ADC node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `vddout25` regulator node uses a deprecated node name pattern (`fixed-regulator-vddout25`) that violates devicetree standards.
--

--- Patch [12]: [PATCH v5 12/17] ARM: dts: microchip: sama7d65: Add ADC node ---
commit 1acc23759ae718683d0ee0863abd37a91d3f243a
Author: Varshini Rajendran <[email protected]>

ARM: dts: microchip: sama7d65: Add ADC node

Add node for the ADC controller in sama7d65 SoC. Add the vddout25 fixed
regulator node which provides the 2.5V reference voltage for the ADC.

> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index dfac17e34e651..c35f27615bc49 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi

[ ... ]

> @@ -95,6 +96,15 @@ slow_xtal: clock-slowxtal {
>  		};
>  	};
>  
> +	vddout25: fixed-regulator-vddout25 {

[Severity: Low]
Does this node name trigger dtbs_check warnings? The naming pattern
fixed-regulator-* falls under the deprecated path in fixed-regulator.yaml,
which prefers names matching ^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$.

> +		compatible = "regulator-fixed";
> +		regulator-name = "VDDOUT25";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-boot-on;
> +		status = "disabled";
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12