Re: [PATCH v5 11/17] ARM: dts: microchip: sama7d65: add cpu opps

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `cpu-supply` property in the board device tree leads to CPU undervolting and system crash.
--

--- Patch [11]: [PATCH v5 11/17] ARM: dts: microchip: sama7d65: add cpu opps ---
commit fc836a1a8220dc67fbc068b60857dc5200abf5d0
Author: Varshini Rajendran <[email protected]>

ARM: dts: microchip: sama7d65: add cpu opps

This commit adds the CPU operating performance points (OPP) table for the
SAMA7D65 SoC. It links the OPP table to the cpu0 node, enabling dynamic
frequency scaling for the CPU.

> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index ec200848c153f..dfac17e34e651 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -35,6 +35,7 @@ cpu0: cpu@0 {
>  			d-cache-size = <0x8000>;	// L1, 32 KB
>  			i-cache-size = <0x8000>;	// L1, 32 KB
>  			next-level-cache = <&L2>;
> +			operating-points-v2 = <&cpu_opp_table>;

[Severity: High]
Will this cause the system to crash due to CPU undervolting during frequency
scaling?

Adding the operating-points-v2 property activates the cpufreq-dt driver.
However, the board device tree (at91-sama7d65_curiosity.dts) appears to be
missing a cpu-supply property for the cpu0 node to link it with the PMIC
regulator.

The cpufreq-dt driver gracefully tolerates missing regulators and will
proceed to dynamically scale the CPU frequency based on load. When the
frequency is raised (for example, to 1GHz, which requires 1.25V), the PMIC
voltage will remain at its default boot value.

Does the cpu0 node in the board file need to be updated with cpu-supply
to ensure the voltage scales safely alongside the frequency?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11