Re: [PATCH v5 14/17] ARM: dts: microchip: sama7d65: add otpc node
[email protected] Tue, 04 Aug 2026 12:53:08 +0000
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Unused dt-bindings header included in sama7d65.dtsi -- --- Patch [14]: [PATCH v5 14/17] ARM: dts: microchip: sama7d65: add otpc node --- commit 2c133d1669c4d7c5ae4cff5a6ba5a348f2ab2163 Author: Varshini Rajendran <[email protected]> ARM: dts: microchip: sama7d65: add otpc node Add OTPC node along with temperature calibration cell. > diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi > index c35f27615bc49..aac2e22d96cb3 100644 > --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi > +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi > @@ -15,6 +15,7 @@ > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/mfd/at91-usart.h> > +#include <dt-bindings/nvmem/microchip,sama7g5-otpc.h> [Severity: Low] This isn't a bug, but is this include necessary? It looks like the temperature calibration data node uses a direct FourCC TAG address instead of any macros that might be provided by this header. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=14