Re: [PATCH 01/10] dt-bindings: mfd: ene-kb[3]930: Use generic power-controller schema
| Newsgroups | org.kernel.vger.linux-devicetree,dev.linux.lists.mfd |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Broken schema reference to non-existent power-controller.yaml -- --- Patch [1]: [PATCH 01/10] dt-bindings: mfd: ene-kb[3]930: Use generic power-controller schema --- commit 7180a65c7f429628f30dced562271d7d6ecc790b Author: Peng Fan <[email protected]> dt-bindings: mfd: ene-kb[3]930: Use generic power-controller schema Convert the binding to use the generic power-controller schema instead by referencing power-controller.yaml and removing the local system-power-controller property definition. > diff --git a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > index 9b11b6e2bbf74..1847a6d5b22e8 100644 > --- a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > +++ b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml > @@ -13,6 +13,9 @@ description: | > maintainers: > - Lubomir Rintel <[email protected]> > > +allOf: > + - $ref: /schemas/power/power-controller.yaml# [Severity: Low] Does the /schemas/power/power-controller.yaml schema exist in the tree? If the generic power-controller properties are only defined in a legacy text binding (Documentation/devicetree/bindings/power/power-controller.txt) and have not yet been converted to YAML, make dt_binding_check will fail because this reference cannot be resolved. Additionally, since unevaluatedProperties is set to false, will removing the local system-power-controller property definition cause the example to be rejected as having an undocumented property? [ ... ] > diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml > index 02c111def5de5..e0c8abf95bd92 100644 > --- a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml > +++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml > @@ -13,7 +13,9 @@ description: | > maintainers: > - Dmitry Osipenko <[email protected]> > > -$ref: /schemas/power/supply/power-supply.yaml > +allOf: > + - $ref: /schemas/power/supply/power-supply.yaml > + - $ref: /schemas/power/power-controller.yaml# [Severity: Low] Similarly, will this reference to a non-existent schema file break dt_binding_check validation here? [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1