Re: [PATCH 1/2] dt-bindings: regulator: ti,tps65219: Use generic power-controller schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch references a non-existent generic YAML schema `/schemas/power/power-controller.yaml#`.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: regulator: ti,tps65219: Use generic power-controller schema ---
commit cf2a7a6bb686cde6c0c0239ec4f30d1057f13e9e
Author: Peng Fan <[email protected]>

dt-bindings: regulator: ti,tps65219: Use generic power-controller schema

This commit converts the ti,tps65219 binding to use the generic power
controller schema by removing the local system-power-controller property
and referencing power-controller.yaml.

> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> index 7c64e588a8b54..d3a82aa7319f0 100644
> --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml

[ ... ]

> @@ -99,9 +94,10 @@ required:
>    - interrupts
>    - regulators
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  allOf:
> +  - $ref: /schemas/power/power-controller.yaml#

[Severity: Low]
Does this generic schema actually exist in the kernel tree yet? It appears
the target might still be power-controller.txt, meaning this reference could
cause dt_binding_check validation to fail with a schema resolution error.

>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1