Re: [PATCH 2/2] dt-bindings: regulator: act8x: Use generic power-controller schema
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Broken schema cross-reference to a non-existent power-controller.yaml file. -- --- Patch [2]: [PATCH 2/2] dt-bindings: regulator: act8x: Use generic power-controller schema --- commit dbd959e51dadcb9629319a89cca123c97aebf588 Author: Peng Fan <[email protected]> dt-bindings: regulator: act8x: Use generic power-controller schema Convert the binding to use the generic power-controller schema instead by referencing power-controller.yaml and removing the local system-power-controller property definition. > diff --git a/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml b/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml > index b8ca967bc83d1..49f74a9b1eaab 100644 > --- a/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml > +++ b/Documentation/devicetree/bindings/regulator/active-semi,act8600.yaml > @@ -9,6 +9,9 @@ title: Active-semi ACT8600 regulator > maintainers: > - Paul Cercueil <[email protected]> > > +allOf: > + - $ref: /schemas/power/power-controller.yaml# [Severity: Low] Does this reference break dt_binding_check? It appears that /schemas/power/power-controller.yaml does not exist in the tree yet, as only the legacy power-controller.txt is present in Documentation/devicetree/bindings/power/. Are there missing prerequisite patches for this series? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2