Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree schema references a missing generic schema file (`/schemas/power/power-controller.yaml#`), which breaks schema validation.
--
--- Patch [8]: [PATCH 08/10] dt-bindings: mfd: rohm,bd71828-pmic: Use generic power-controller schema ---
commit fe53293ad6a768dfc275a4c74e7fe894633d1720
Author: Peng Fan <[email protected]>
dt-bindings: mfd: rohm,bd71828-pmic: Use generic power-controller schema
This patch updates the bd71828-pmic binding to use the generic power
controller schema. It references power-controller.yaml, removes the local
system-power-controller property, and switches additionalProperties to
unevaluatedProperties.
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> index 09e7d68e92bf3..9818102e02c75 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> @@ -15,6 +15,9 @@ description: |
> single-cell linear charger. Also included is a Coulomb counter, a real-time
> clock (RTC), and a 32.768 kHz clock gate.
>
> +allOf:
> + - $ref: /schemas/power/power-controller.yaml#
[Severity: Low]
Does this reference resolve correctly in the current tree? It appears that
power-controller.yaml has not been converted yet, and only the original
power-controller.txt exists in Documentation/devicetree/bindings/power/.
If the target schema file is missing, dtschema will be unable to resolve
the reference, which causes schema validation to fail when running
make dt_binding_check.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.