Re: [PATCH v9 28/36] pinctrl: airoha: an7583: add support for npu_uart pinmux

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'npu_uart' pin group was not added to the devicetree bindings schema for airoha,an7583-pinctrl.
--

--- Patch [28]: [PATCH v9 28/36] pinctrl: airoha: an7583: add support for npu_uart pinmux ---
commit 4aada6051d08f6809c3042f7ef7adb433db84857
Author: Mikhail Kshevetskiy <[email protected]>

pinctrl: airoha: an7583: add support for npu_uart pinmux

This commit adds support for the npu_uart pin function group to the 
airoha an7583 pinctrl driver.

> diff --git a/drivers/pinctrl/airoha/pinctrl-an7583.c b/drivers/pinctrl/airoha/pinctrl-an7583.c
> index 44efccce78c55..dc88cbd8746bb 100644
> --- a/drivers/pinctrl/airoha/pinctrl-an7583.c
> +++ b/drivers/pinctrl/airoha/pinctrl-an7583.c

[ ... ]

> @@ -571,7 +572,7 @@ static const char *const sipo_groups[] = { "sipo", "sipo_rclk" };
>  static const char *const mdio_groups[] = { "mdio" };
>  static const char *const uart_groups[] = {
>  	"uart2", "uart2_cts_rts", "hsuart", "hsuart_cts_rts",
> -	"uart4", "uart5"
> +	"uart4", "uart5", "npu_uart"

[Severity: Low]
Does this code need a corresponding update to the device tree bindings?

Looking at Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml,
it restricts the allowed 'uart' groups and lacks the newly added 'npu_uart'.
Will this cause dtbs_check validation to fail for any device tree using the
newly added 'npu_uart' group?

>  };
>  static const char *const i2c_groups[] = { "i2c0", "i2c1" };
>  static const char *const jtag_groups[] = { "jtag_udi", "jtag_dfd" };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=28