Re: [PATCH v9 36/36] dt-bindings: pinctrl: airoha: add support of an7563 pin controller

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example uses deprecated uint32 syntax for the boolean property `drive-open-drain`.
--

--- Patch [36]: [PATCH v9 36/36] dt-bindings: pinctrl: airoha: add support of an7563 pin controller ---
commit 6b301b6a4c35b1cd7c701f2fde3e4da82cdaf6b9
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: add support of an7563 pin controller

This patch adds device tree binding schema for the Airoha AN7563 SoC pin
controller.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml
> new file mode 100644
> index 0000000000000..e626d34661285
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    pinctrl {

[ ... ]

> +      pcie1-rst-pins {
> +        conf {
> +          pins = "pcie_reset1";
> +          drive-open-drain = <1>;

[Severity: Low]
Does this example use deprecated syntax for a boolean property?

The schema pincfg-node.yaml explicitly marks `<1>` as deprecated for
`drive-open-drain`. Downstream developers might copy this deprecated syntax
into their device trees.

> +        };
> +      };

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=36