Re: [PATCH v9 06/10] dt-bindings: clock: qcom: Add support for CAMCC for Eliza

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding unconditionally requires `#power-domain-cells` for all compatibles, incorrectly forcing the BIST MCLK controller (`qcom,eliza-cambistmclkcc`) to act as a power domain provider.
--

--- Patch [6]: [PATCH v9 06/10] dt-bindings: clock: qcom: Add support for CAMCC for Eliza ---
commit 3b7afe439852001ef758258be71850042fc0ea32
Author: Taniya Das <[email protected]>

dt-bindings: clock: qcom: Add support for CAMCC for Eliza

This commit adds compatible strings for the Eliza camera and camera BIST
clock controllers to the Milos camcc binding. It also includes new header
files for the clocks and modifies the schema to require the
#power-domain-cells property.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> index c4aba40e316ca..cf7df47acbe7f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
[ ... ]
> @@ -8,16 +8,23 @@ title: Qualcomm Camera Clock & Reset Controller on Milos
>  
>  maintainers:
>    - Luca Weiss <[email protected]>
> +  - Taniya Das <[email protected]>
>  
>  description: |
>    Qualcomm camera clock control module provides the clocks, resets and power
>    domains on Milos.
>  
> -  See also: include/dt-bindings/clock/qcom,milos-camcc.h
> +  See also:
> +    include/dt-bindings/clock/qcom,eliza-cambistmclkcc.h
> +    include/dt-bindings/clock/qcom,eliza-camcc.h
> +    include/dt-bindings/clock/qcom,milos-camcc.h
>  
>  properties:
>    compatible:
> -    const: qcom,milos-camcc
> +    enum:
> +      - qcom,eliza-cambistmclkcc
> +      - qcom,eliza-camcc
> +      - qcom,milos-camcc
>  
>    clocks:
>      items:
[ ... ]
> @@ -44,6 +51,7 @@ required:
>    - clocks
>    - power-domains
>    - required-opps
> +  - '#power-domain-cells'

[Severity: Medium]
Does adding #power-domain-cells to the global required properties force
the qcom,eliza-cambistmclkcc hardware to incorrectly act as a power domain
provider?

Looking at the new header include/dt-bindings/clock/qcom,eliza-cambistmclkcc.h,
the BIST MCLK controller appears to define only clocks, lacking any power
domains or resets.

Because #power-domain-cells is now unconditionally required here, will a
device tree node for the BIST controller fail dtbs_check if it accurately
omits the #power-domain-cells property? Would it be appropriate to isolate
the unique constraints for qcom,eliza-cambistmclkcc using a conditional block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6