Re: [PATCH v2 2/4] dt-bindings: iio: light: ltr501: Add ltr329 compatible

On Tue, 04 Aug 2026 16:35:27 +0200
Esben Haabendal <[email protected]> wrote:

> "Jonathan Cameron" <[email protected]> writes:
> 
> > On Thu, 16 Jul 2026 16:14:55 +0000
> > Esben Haabendal <[email protected]> wrote:
> >  
> >> On Thursday, 16 July 2026 at 10:07, Krzysztof Kozlowski <[email protected]> wrote:
> >>  
> >> > On Wed, Jul 15, 2026 at 02:27:24PM +0200, Esben Haabendal wrote:  
> >> > > LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
> >> > > without interrupt support.
> >> > >
> >> > > Signed-off-by: Esben Haabendal <[email protected]>
> >> > > ---
> >> > >  Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml | 1 +
> >> > >  1 file changed, 1 insertion(+)
> >> > >
> >> > > diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> >> > > index ab9bb68dd736..76e81eba7ea4 100644
> >> > > --- a/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> >> > > +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> >> > > @@ -19,6 +19,7 @@ properties:
> >> > >        - liteon,ltr559
> >> > >        - liteon,ltr301
> >> > >        - liteon,ltr303
> >> > > +      - liteon,ltr329  
> >> >
> >> > Do not grow lists at the end, they are ordered alphanumerically to avoid
> >> > conflicts.  
> >>
> >> Placing the new entry at the top would produce a rather strangely order list:
> >>
> >> ltr329
> >> ltr501
> >> ltr559
> >> ltr301
> >> ltr329
> >>
> >> Should I add a patch sorting the entire list to avoid this kind of
> >> confusion in the future?  
> >
> > Please do a precursor patch for that  Also do it for the id tables in the driver.  
> 
> Ok. Sorting ltr501_id and ltr501_of_match should be trivial.
> But what about ltr501_chip_info_tbl (and the anonymous enum used to
> index it, should they be sorted as well? And ltr301 being 0 instead of
> ltr501, the original device the driver was written for?
Sure. The numbers don't mean anything in particular afterall.

Good point to raise.

Jonathan

> 
> /Esben
>