Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Custom devicetree properties lack required vendor prefixes, missing explicit type definitions, and misuse array validation syntax for scalar values.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 ---
commit 3134bea94c0e8c33141972ee2792aabe8a1104e9
Author: Kyle Hsieh <[email protected]>
dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04
Add device tree binding documentation for Texas Instruments ADS112C04
I2C Analog-to-Digital Converters. The binding uses child nodes to
dynamically define the connected single-ended or differential channels.
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
> new file mode 100644
> index 0000000000000..ff079bb5b3dd9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
[ ... ]
> +patternProperties:
> + "^channel@[0-9a-b]$":
> + $ref: adc.yaml
> + unevaluatedProperties: false
> + properties:
[ ... ]
> + excitation-channels:
> + maxItems: 2
> + items:
> + maximum: 3
> +
> + excitation-current-nanoamp:
> + maxItems: 2
> + items:
> + enum: [10000, 50000, 100000, 250000, 500000, 1000000, 1500000]
> +
> + burn-out-current-nanoamp:
> + items:
> + - enum: [10000]
> +
> + reference-sources:
> + items:
> + - enum: [internal-2.048v, external, avdd]
> + default: internal-2.048v
[Severity: Low]
Should these custom device-specific properties (excitation-channels,
excitation-current-nanoamp, burn-out-current-nanoamp, and reference-sources)
have a "ti," vendor prefix to avoid polluting the global namespace?
Also, burn-out-current-nanoamp and reference-sources appear to incorrectly use
YAML array tuple validation syntax instead of simple scalar schemas. Does
reference-sources also need an explicit type definition to prevent
dt_binding_check failures?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.