Re: [PATCH v4 2/4] clocksource/drivers: Add support for the Renesas RZ/N1 timers

Wolfram Sang <[email protected]>
Newsgroups org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc
Message-ID <anLm0fgzm_TanuMS@shikoro>
> +		if (irq_disabled)
> +			irq_set_status_flags(timer->ced.irq, IRQ_NOAUTOEN);

I just got a buildbot report that the above line needs 'irq.h' to be
included. But I wonder if we can't skip it with:

	flags = IRQF_TIMER;
	if (irq_disabled)
		flags |= IRQF_NO_AUTOEN;

> +		ret = devm_request_irq(dev, timer->ced.irq, rzn1_timer_interrupt,
> +				       IRQF_TIMER, timer->ced.name, timer);

and use 'flags' here?
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmpy5s0ACgkQFA3kzBSg
KbbLKA//WcVbwVkGuPRc8bj8aREUVY3FfdcHNy3nNdDGt8HRld15CrU/hCnYEjq+
R6WvTF79CmECfIFbtPka4EXS8TGuElUrrwgUrehuXXPZ39C9B3u9YEggepoEvZiu
aFLU/1sFmXcnEn+3DtSDVtv3Y5W2zW61j7BU45+Y/5SkxFE+7lqTNgCAIzeX77g9
w7ZLj0qWw4/nS9cJ0zHFebToXV3xR0nwMte5ZEgrSKSI11wECOOgX9VKbV2Sav/J
gVs6BFnTQSQrcb0dR3CvON2KRwodbQLrYKeqdIdZpd/TEPaGZh45QENnIiTxvGQ7
AgkdkANS2WYbazST2VpjGF7A4mn+GYl8uAGz9VM67z/p8H8w8JJbtETSFoHV2QAW
UyECY/4fHLz/gaisX0zFP1ciAiCrgTGcYxl+nAANuTKfWwP/wvC8tsdzXLSrL/ol
AW8dI2WqAh1PCHiEhlommo572JFU4iD+EUgeOMDlK15LlQ6PbMO7g30ZCmUsCYS+
/S+4UY9v5miCEYWRbEf2nwccFfL39ybYgdv5idl3HSWfcNNdh9I+Wtp+hq6W9nwv
3WJ7QymrsCrLAFroV5V2hm3IHtp7ymrP46hlNziBO8Tkv/Zh5ZUr/qIq3KCOyZKD
AgtEb1s7pkkEsvrmN6/lV8MHo7ZBppi6/S4K2JXeWa55Ir7ZrwI=
=h0pA
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.