Re: [PATCH v3 1/3] arm64: dts: qcom: sm8450-hdk: Enable I2S for HDMI

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree topological violation: SoC I2S and MCLK pinctrl states are incorrectly assigned to an external I2C codec node.
--

--- Patch [1]: [PATCH v3 1/3] arm64: dts: qcom: sm8450-hdk: Enable I2S for HDMI ---
commit 1e06799a0230632b985134cd0731cc4a2e53b31d
Author: Neil Armstrong <[email protected]>

arm64: dts: qcom: sm8450-hdk: Enable I2S for HDMI

This commit adds the necessary Device Tree nodes and configurations to enable
I2S audio output via the DSI HDMI bridge on the SM8450 HDK. It defines the
audio clock and pin configurations, links the DAI components, and assigns
the pinctrl states to the HDMI bridge node.

> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index b37998cd9a2c3..6bc2e8630dc37 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -665,7 +665,12 @@ lt9611_codec: hdmi-bridge@2b {
>  		vcc-supply = <&lt9611_3v3>;
>  
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&lt9611_irq_pin &lt9611_rst_pin>;
> +		pinctrl-0 = <&lt9611_irq_pin>,
> +			    <&lt9611_rst_pin>,
> +			    <&i2s0_default_state>,
> +			    <&audio_mclk0_default_state>;

[Severity: Low]
Are the SoC's I2S and MCLK pinctrl states being assigned to the correct
node here?

These pins belong to the host SoC and are driven by its audio controller,
rather than the external LT9611 HDMI bridge. Assigning the SoC's pin
configuration to the external bridge's node makes the codec driver
responsible for configuring the host SoC's hardware, which seems to cross
topological boundaries in the Device Tree.

Should these pins be assigned to the sound card node or the CPU DAI node
instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1