Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Addition of the `apple,t8122-spmi` compatible string is not documented in the commit message.
--
--- Patch [1]: [PATCH v4 1/6] dt-bindings: spmi: apple,spmi: Add t603x ---
commit 3674bf5dbfe7c309c197e5a76b4e84e891ec9d7d
Author: Sasha Finkelstein <[email protected]>
dt-bindings: spmi: apple,spmi: Add t603x
This commit adds device tree binding support for the Apple t603x SPMI
controllers, including optional interrupt support for controllers that are
not always-on.
> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
[ ... ]
> @@ -20,8 +20,11 @@ properties:
> - items:
> - enum:
> - apple,t6020-spmi
> + - apple,t6030-spmi
> + - apple,t6031-spmi
> - apple,t8012-spmi
> - apple,t8015-spmi
> + - apple,t8122-spmi
[Severity: Medium]
The commit message and subject specifically mention adding support for the
t603x series, but this also adds the apple,t8122-spmi compatible string.
Should the commit description be updated to reflect the addition of t8122,
or was this new compatible string intended for a separate patch?
> - const: apple,t8103-spmi
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.