Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing existing device tree board compatible strings breaks backward compatibility with bootloaders and userspace.
--
--- Patch [2]: [PATCH v3 2/4] arm64: dts: qcom: fix PURWA/HAMOA IOT SOM compatibles ---
commit 13bd2c46e7d398444043412a0d95ccdf1938980f
Author: Yuanjie Yang <[email protected]>
arm64: dts: qcom: fix PURWA/HAMOA IOT SOM compatibles
This commit updates the compatible strings for Hamoa and Purwa IoT SOMs to
match their official IQ product names. It removes the undocumented
hamoa-iot-som and purwa-iot-som strings from the DTS files.
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 9fa86bb6438ec..b807079a5ee22 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
[ ... ]
> @@ -6,12 +6,12 @@
> /dts-v1/;
>
> #include <dt-bindings/leds/common.h>
> -#include "hamoa-iot-som.dtsi"
> +#include "iq-x7181-evk-som.dtsi"
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>
> / {
> model = "Qualcomm Technologies, Inc. Hamoa IoT EVK";
> - compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";
> + compatible = "qcom,hamoa-iot-evk", "qcom,iq-x7181-evk-som", "qcom,x1e80100";
[Severity: High]
Does removing the qcom,hamoa-iot-som compatible string break backward
compatibility for existing bootloaders or userspace tools?
Since device tree bindings are generally considered a stable ABI once
released, older bootloaders and userspace scripts (like fwupd or systemd)
identifying the board via qcom,hamoa-iot-som might fail to recognize the
hardware after this update.
Should the new IQ product string be added while keeping the old string
as a fallback?
> chassis-type = "embedded";
>
> aliases {
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> index ad503beec1d3d..d2963af1d762d 100644
> --- a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
[ ... ]
> @@ -6,12 +6,12 @@
> /dts-v1/;
>
> #include <dt-bindings/leds/common.h>
> -#include "purwa-iot-som.dtsi"
> +#include "iq-x5121-evk-som.dtsi"
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>
> / {
> model = "Qualcomm Technologies, Inc. Purwa IoT EVK";
> - compatible = "qcom,purwa-iot-evk", "qcom,purwa-iot-som", "qcom,x1p42100";
> + compatible = "qcom,purwa-iot-evk", "qcom,iq-x5121-evk-som", "qcom,x1p42100";
[Severity: High]
Similarly, does the complete removal of qcom,purwa-iot-som here violate
the stable device tree ABI policy?
Bootloaders and userspace tools relying on the previous string will no longer
recognize the board.
> chassis-type = "embedded";
>
> aliases {
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.