Re: [PATCH v10 12/36] pinctrl: airoha: fix AN7583 MDIO pin mux config

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `mdio1` pin group is orphaned, completely unmapped to any pin function, and points to pins that actually belong to `i2c1`, making it useless dead code.
--

--- Patch [12]: [PATCH v10 12/36] pinctrl: airoha: fix AN7583 MDIO pin mux config ---
commit 7aba565954d9e66108d9e018ec2a6fd970bf13e4
Author: Daniel Schwierzeck <[email protected]>

pinctrl: airoha: fix AN7583 MDIO pin mux config

This commit fixes the MDIO pin multiplexing configuration for the AN7583 SoC.
It updates the MDIO pins to use the correct indices (53, 54) instead of the
I2C1 pins. It also corrects the register mask values written by the function
group.

> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -724,7 +724,8 @@ static const int an7583_pon_tod_1pps_pins[] = { 32 };
>  static const int an7583_gsw_tod_1pps_pins[] = { 32 };
>  static const int an7583_sipo_pins[] = { 34, 35 };
>  static const int an7583_sipo_rclk_pins[] = { 34, 35, 33 };
> -static const int an7583_mdio_pins[] = { 43, 44 };
> +static const int an7583_mdio_pins[] = { 53, 54 };
> +static const int an7583_mdio1_pins[] = { 43, 44 };

[Severity: Low]
Is this mdio1 pin array intended to be used?

Since pins 43 and 44 are already covered by the I2C1 pins (as noted in the
commit message), it appears this might just be leftover dead code from
renaming the original mdio pins rather than an intentionally usable array.

[ ... ]

> @@ -809,6 +810,7 @@ static const struct pingroup an7583_pinctrl_groups[] = {
>  	PINCTRL_PIN_GROUP("sipo", an7583_sipo),
>  	PINCTRL_PIN_GROUP("sipo_rclk", an7583_sipo_rclk),
>  	PINCTRL_PIN_GROUP("mdio", an7583_mdio),
> +	PINCTRL_PIN_GROUP("mdio1", an7583_mdio1),

[Severity: Low]
Does this mdio1 group need to be mapped to a function to be useful?

As currently implemented, the group is registered here but is completely
unmapped to any pin function in the driver, which makes it unusable for
multiplexing. 

Could this registration be safely removed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12