Re: [PATCH 1/2] dt-bindings: dp83867: add binding for output-impedance

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing schema constraints for numeric property bounds.
- [Low] Devicetree property naming convention violation (-ohms).
--

--- Patch [1]: [PATCH 1/2] dt-bindings: dp83867: add binding for output-impedance ---
commit 9c13d3ae2983ce2a58c2c0ce9fcf6fedc072b384
Author: Steffen Trumtrar <[email protected]>

dt-bindings: dp83867: add binding for output-impedance

This commit adds a new devicetree property, ti,output-impedance, to configure 
the MAC interface output impedance to a fixed value. It also specifies 
precedence rules when used alongside existing impedance configuration properties.

> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> @@ -41,6 +41,12 @@ properties:
>      items:
>        - const: io_impedance_ctrl
>  
> +  ti,output-impedance:

[Severity: Low]
This isn't a bug, but should this property name include a standard unit suffix?

According to dtschema conventions for physical units, resistance properties 
typically use a suffix like -ohms or -micro-ohms (e.g., ti,output-impedance-ohms).

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      MAC Interface Impedance control to set the programmable output impedance
> +      to a value between minimum (35 ohms) and maximum (70 ohms).

[Severity: Low]
Should this property definition include minimum: 35 and maximum: 70 constraints?

The documentation mentions the allowed range, but without explicit JSON schema 
constraints, dt_binding_check will silently allow out-of-bounds values in 
device trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1