Re: [PATCH v10 34/36] dt-bindings: pinctrl: airoha: add support of en7523 pin controller

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing label for phandle reference in device tree example
- [Low] Usage of deprecated integer assignment for `drive-open-drain` in example
--

--- Patch [34]: [PATCH v10 34/36] dt-bindings: pinctrl: airoha: add support of en7523 pin controller ---
commit 09684fda82523cf1b5b0d87b6f829c268435150a
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: add support of en7523 pin controller

This patch adds device tree binding schema for Airoha EN7523 SoC pin
controller.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,en7523-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,en7523-pinctrl.yaml
> new file mode 100644
> index 0000000000000..599f80e94432b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,en7523-pinctrl.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    pinctrl {
> +      compatible = "airoha,en7523-pinctrl";
> +
> +      interrupt-parent = <&gic>;
> +      interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +
> +      gpio-controller;
> +      #gpio-cells = <2>;
> +
> +      interrupt-controller;
> +      #interrupt-cells = <2>;
> +
> +      gpio-ranges = <&pinctrl 0 12 30>;

[Severity: Low]
Will this example fail dt_binding_check compilation? The gpio-ranges
property references the &pinctrl phandle, but there is no pinctrl: label
defined on the root node in this example.

> +
> +      pcie1-rst-pins {
> +        conf {
> +          pins = "pcie_reset1";
> +          drive-open-drain = <1>;

[Severity: Low]
Does this use a deprecated integer assignment? The generic pincfg-node.yaml
schema typically expects the boolean flag drive-open-drain; rather than
assigning a value.

> +        };
> +      };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=34