Re: [PATCH v4 11/12] ARM: dts: aspeed: anacapa: Simplify leakage GPIO line names
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Commit message body inaccurately limits the scope of the change to 'leakage present' signals, whereas the patch also updates standard 'leakage' signals. -- --- Patch [11]: [PATCH v4 11/12] ARM: dts: aspeed: anacapa: Simplify leakage GPIO line names --- commit e7d857ae3e79d3f73dec753a5762ce9623e510c0 Author: Rex Fu <[email protected]> ARM: dts: aspeed: anacapa: Simplify leakage GPIO line names This commit simplifies GPIO line names by removing board location suffixes. It updates names for both standard leakage and leakage present signals in the anacapa device tree. > Remove the board location suffixes from the leakage present GPIO line > names. The channel number is enough to identify each leakage present > signal. [Severity: Low] This isn't a bug, but does the commit message body unnecessarily limit the scope of the change? The text only mentions modifying "leakage present" signals, but the patch itself also modifies standard "leakage" signals (for example, changing "Channel0_leakage_EAM3" to "Channel0_leakage" in sgpiom0). Could the commit message be updated to clarify that both standard leakage and leakage present signals are being renamed? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260805-anacapa-devlop-phase-devicetree-v4-0-5d67e0efa6c5@gmail.com?part=11