Re: [PATCH 2/2] arm64: dts: rockchip: Fix the BT clock-names on rk3399-leez-p710

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect clock-name 'txco' used for a 32.768 kHz LPO clock.
--

--- Patch [2]: [PATCH 2/2] arm64: dts: rockchip: Fix the BT clock-names on rk3399-leez-p710 ---
commit 6ad4dd81542316e95c763ba942c066130a8d8bba
Author: Fabio Estevam <[email protected]>

arm64: dts: rockchip: Fix the BT clock-names on rk3399-leez-p710

This commit changes the bluetooth clock-names property from ext_clock
to txco to resolve a dt-schema warning.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts b/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts
> --- a/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts
> @@ -588,7 +588,7 @@ &uart0 {
>  	bluetooth {
>  		compatible = "brcm,bcm43438-bt";
>  		clocks = <&rk808 1>;
> -		clock-names = "ext_clock";
> +		clock-names = "txco";

[Severity: Low]
Should this be named lpo instead of txco?

The clock provided by <&rk808 1> corresponds to the RK808 PMIC's clkout2,
which is a fixed 32.768 kHz clock.

According to the brcm,bluetooth.yaml dt-bindings, an external low-power
32.768 kHz clock must be named lpo, whereas txco is reserved for
high-frequency reference clocks. Other boards with the exact same hardware
configuration correctly use lpo for <&rk808 1>.

>  		device-wakeup-gpios = <&gpio2 RK_PD2 GPIO_ACTIVE_HIGH>;
>  		host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
>  		shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2