Re: [PATCH v3 4/5] dt-bindings: serial: snps-dw-apb-uart: Add StarFive JHB100 UART compatible

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing Compatible String in Conditional Block
--

--- Patch [4]: [PATCH v3 4/5] dt-bindings: serial: snps-dw-apb-uart: Add StarFive JHB100 UART compatible ---
commit 58551d4cd9febd373c92800fceea07e37197bb0a
Author: Changhuang Liang <[email protected]>

dt-bindings: serial: snps-dw-apb-uart: Add StarFive JHB100 UART compatible

Add "starfive,jhb100-uart" compatible string, with "snps,dw-apb-uart"
as the fallback.

> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 49f51b0028795..bca297c22fda5 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -78,6 +78,7 @@ properties:
>                - starfive,jh7100-hsuart
>                - starfive,jh7100-uart
>                - starfive,jh7110-uart
> +              - starfive,jhb100-uart

[Severity: Medium]
Does the starfive,jhb100-uart hardware also require 2 resets like the
jh7110-uart?

If so, should it be added to the conditional block earlier in this file?
Without it, device trees specifying 2 resets for jhb100-uart will fail
schema validation because they will fall into the else block which limits
resets to a maxItems of 1:

allOf:
[ ... ]
  - if:
      properties:
        compatible:
          contains:
            const: starfive,jh7110-uart
    then:
      properties:
        resets:
          minItems: 2
    else:
      properties:
        resets:
          maxItems: 1

>                - ultrarisc,dp1000-uart
>            - const: snps,dw-apb-uart

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4