Re: [PATCH v11 11/37] dt-bindings: pinctrl: airoha: an7583: add i2c0 group for i2c function

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch adds the 'i2c0' group to the 'i2c' function in the dt-binding, and the commit message claims to 'add mux to force enable i2c0 bus', but the corresponding pinctrl driver changes are missing. As a result, if a device tree uses `groups = "i2c0"` with `function = "i2c"`, the pinctrl framework will reject it because the driver lacks the mapping to accept 'i2c0' as a valid group for the 'i2c' function.
--

--- Patch [11]: [PATCH v11 11/37] dt-bindings: pinctrl: airoha: an7583: add i2c0 group for i2c function ---
commit d3e9c23e02c56f531e4cd4f03dc53d38958eaaea
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: an7583: add i2c0 group for i2c function

This commit updates the device tree binding for the Airoha AN7583 pinctrl
controller to allow the i2c0 group under the i2c function.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> index 3e680c997fe26..24f1ac60eea84 100644
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> @@ -124,7 +124,7 @@ patternProperties:
>              then:
>                properties:
>                  groups:
> -                  enum: [i2c1]
> +                  enum: [i2c0, i2c1]
                  ^^^^

[Severity: Medium]
Is there a missing accompanying driver update to support this newly added
group?

If a device tree is updated to use groups = "i2c0" with function = "i2c", won't
the pinctrl framework reject it because the driver only maps i2c1?

Looking at drivers/pinctrl/airoha/pinctrl-airoha.c, the i2c function appears
to hardcode only the i2c1 group:

drivers/pinctrl/airoha/pinctrl-airoha.c:i2c_groups
static const char *const i2c_groups[] = { "i2c1" };

The register mapping for i2c0 also appears to be missing from the
associated function group array:

drivers/pinctrl/airoha/pinctrl-airoha.c:i2c_func_group
static const struct airoha_pinctrl_func_group i2c_func_group[] = {
	{
		.name = "i2c1",
        ...

Will the driver also be patched so that i2c_func_group and i2c_groups know
how to handle i2c0?

>            - if:
>                properties:
>                  function:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11