Re: [PATCH v11 13/37] pinctrl: airoha: fix AN7583 MDIO pin mux config

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced `mdio1` pin group is orphaned, unmapped to any multiplexing function, and redundant since its pins are already covered by the `i2c1` group.
--

--- Patch [13]: [PATCH v11 13/37] pinctrl: airoha: fix AN7583 MDIO pin mux config ---
commit a5b09e70184114d2a027b043ce8c8831ef4960fb
Author: Daniel Schwierzeck <[email protected]>

pinctrl: airoha: fix AN7583 MDIO pin mux config

This commit corrects the pin numbers and register masks for the AN7583 MDIO
mux configuration. It updates the MDIO pin array to use pins 53 and 54, and
modifies the function group to clear the correct hardware initialization bits.

> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index 7de07d002d05f..6dff1d01f4b51 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -724,7 +724,8 @@ static const int an7583_pon_tod_1pps_pins[] = { 32 };
[ ... ]
>  static const int an7583_sipo_rclk_pins[] = { 34, 35, 33 };
> -static const int an7583_mdio_pins[] = { 43, 44 };
> +static const int an7583_mdio_pins[] = { 53, 54 };
> +static const int an7583_mdio1_pins[] = { 43, 44 };

[Severity: Low]
This isn't a bug, but is this new mdio1 pin array necessary? Pins 43 and 44
are already covered by the i2c1 group.

>  static const int an7583_uart2_pins[] = { 34, 35 };

[ ... ]

> @@ -809,6 +810,7 @@ static const struct pingroup an7583_pinctrl_groups[] = {
>  	PINCTRL_PIN_GROUP("sipo", an7583_sipo),
>  	PINCTRL_PIN_GROUP("sipo_rclk", an7583_sipo_rclk),
>  	PINCTRL_PIN_GROUP("mdio", an7583_mdio),
> +	PINCTRL_PIN_GROUP("mdio1", an7583_mdio1),

[Severity: Low]
Does this new group need to be mapped to a multiplexing function? 

It appears to be orphaned since it is registered here but never added to any
function group mapping arrays, making it unrequestable by the pinmux
framework.

>  	PINCTRL_PIN_GROUP("uart2", an7583_uart2),

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13