Re: [PATCH v11 36/37] dt-bindings: pinctrl: airoha: add support of an7563 pin controller

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example uses a deprecated integer assignment for the boolean `drive-open-drain` property.
--

--- Patch [36]: [PATCH v11 36/37] dt-bindings: pinctrl: airoha: add support of an7563 pin controller ---
commit 19964a175dff853355fc62b6f1ae7edafb571f45
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: add support of an7563 pin controller

This commit introduces the device tree binding schema for the Airoha
AN7563 SoC pin controller.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml
> new file mode 100644
> index 0000000000000..6d186ebe4a41b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7563-pinctrl.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    pinctrl {
> +      compatible = "airoha,an7563-pinctrl";

[ ... ]

> +      pcie1-rst-pins {
> +        conf {
> +          pins = "pcie_reset1";
> +          drive-open-drain = <1>;

[Severity: Low]
This isn't a bug, but should this example use the standard boolean flag format?

According to the core pincfg-node schema, assigning a uint32 value like <1>
to drive-open-drain is deprecated. It could be written simply as
drive-open-drain; to avoid propagating deprecated syntax into downstream
device trees and triggering dt_binding_check warnings.

> +        };
> +      };

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=36