Re: [PATCH net-next v1 2/2] net: dsa: realtek: rtl83xx: add support for enabling supplies
Ahmad Fatoum <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Hello, On 8/7/26 9:10 AM, Oleksij Rempel wrote: > On Fri, Aug 07, 2026 at 08:51:53AM +0200, Linus Walleij wrote: >> On Fri, Aug 7, 2026 at 6:26 AM Oleksij Rempel <[email protected]> wrote: >>> On Thu, Aug 06, 2026 at 07:40:29PM +0200, Linus Walleij wrote: >>>> On Thu, Aug 6, 2026 at 5:56 PM Ahmad Fatoum <[email protected]> wrote: >>>> >>>> [Andrew says] >>>>> So devm_regulator_bulk_get() is already the "optional" variant, but it causes >>>>> all existing users to get dummy supply warnings. >>>> >>>> So is this a big problem? Does it cause any other issues than >>>> dmesg noise? >>> >>> As tested with local sashiko setup, new warnings for existing system >>> without good reason will be reported as regression, so it will be >>> blocker for net-next inclusion. >> >> Strong reverse centaur (*) warning on this one. >> >> I'm not sure this is how Mark want such "regressions" to be treated. >> >> I think a few dummy supplies is just fine and it's rather that Sashiko >> need to be taught not to treat that as bugs/regressions. >> >> Yours, >> Linus Walleij >> >> (*) Reverse centaur = humans touted to please AI, as opposed >> to AI helping humans, sarcastic term coined by author Cory Doctorow. > > Without context, I would fully agree with this statement. But as some > one who need to adders new warnings on every kernel update for our > customers, I see the point of sashiko - new unnecessary warning > is extra unnecessary work for some one else == regression. I also think we shouldn't dump 6 new warnings on other users if their setup is working ok. Cheers, Ahmad > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |