Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Standard properties 'orientation' and 'rotation' bypass standard type validation.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding ---
commit d490efc51c8d22ea84e9e5b16150e2d9e4816d7b
Author: Alexander Shiyan <[email protected]>

dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

This commit adds a devicetree binding for the onsemi AR0234 CMOS image sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml

[ ... ]

> +  vdd-supply:
> +    description: Digital Core (1.2V) supply regulator
> +
> +  vddio-supply:
> +    description: I/O (1.8V-2.8V) supply regulator
> +
> +  orientation: true
> +  rotation: true

[Severity: Low]
Does declaring these standard properties as 'true' bypass the strict type
and enum validation defined in video-interface-devices.yaml?

It looks like this is done to circumvent the 'additionalProperties: false'
constraint, but it would allow device trees with malformed values for
orientation or rotation to silently pass schema validation.

> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    description: CSI-2 transmitter port

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1