Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add imx708 image sensor

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Swapped descriptions and voltages for VDIG and VDDL supplies risk hardware damage.
- [Medium] Missing Common Schema Reference blocks standard video interface properties.
--

--- Patch [1]: [PATCH v2 1/3] dt-bindings: media: i2c: Add imx708 image sensor ---
commit 2d548d9db5698aed5ad6188c54ce0ae5aa972fd7
Author: Jai Luthra <[email protected]>

dt-bindings: media: i2c: Add imx708 image sensor

Adds device tree bindings for the Sony IMX708 image sensor. It defines the
required properties, regulators, port structure, and includes an example
configuration.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml
> new file mode 100644
> index 0000000000000..e41b3ca537063
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml
> @@ -0,0 +1,120 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
[ ... ]
> +properties:
> +  compatible:
> +    const: sony,imx708
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  vdig-supply:
> +    description:
> +      Digital I/O voltage supply, 1.1 volts

[Severity: High]
Are the voltages and descriptions for vdig-supply and vddl-supply swapped
here? Standard Sony CMOS sensors typically use 1.8V for I/O (vdig) and
1.1V/1.2V for the core (vddl). Supplying 1.8V to a 1.1V digital core might
cause permanent hardware damage if integrators follow this description.

> +
> +  vana1-supply:
> +    description:
> +      Analog1 voltage supply, 2.8 volts
> +
> +  vana2-supply:
> +    description:
> +      Analog2 voltage supply, 1.8 volts
> +
> +  vddl-supply:
> +    description:
> +      Digital core voltage supply, 1.8 volts
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdig-supply
> +  - vana1-supply
> +  - vana2-supply
> +  - vddl-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Medium]
Will this strict rejection of additional properties prevent device trees from
specifying standard physical attributes like orientation and rotation?

Typically, an allOf block including a reference to
/schemas/media/video-interface-devices.yaml# is added near the properties
block to inherit these common hardware properties, and unevaluatedProperties
is used instead of additionalProperties. Without the common reference, valid
hardware descriptions may fail validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1