Re: [PATCH v15 12/22] dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `i2c-alias-pool` property is artificially restricted to a maximum of 2 items, breaking validation for standard dual-link camera configurations.
--

--- Patch [12]: [PATCH v15 12/22] dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A ---
commit e68b0ac7c49e56511d1d1a563e3454615bdf8543
Author: Cosmin Tanislav <[email protected]>

dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

This commit introduces device tree bindings for the Maxim MAX9296A, MAX96716A,
and MAX96792A GMSL to CSI-2 deserializers. It defines constraints for the
various supported properties, including ports, power supplies, and the I2C
address translator layout.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml
> new file mode 100644
> index 0000000000000..de6bfcec5dc63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml
[ ... ]
> +  port0-poc-supply:
> +    description: Regulator providing Power over Coax for GMSL port 0
> +
> +  port1-poc-supply:
> +    description: Regulator providing Power over Coax for GMSL port 1
> +
> +  i2c-alias-pool:
> +    maxItems: 2

[Severity: Medium]
Will this limit of 2 items break validation for standard dual-link camera
configurations?

A typical setup with two GMSL links often includes two serializers and two
image sensors. Such a configuration would require at least 4 I2C aliases in
the pool to translate all remote peripheral addresses.

Does this constraint incorrectly map to the number of GMSL links rather than
the expected number of remote I2C devices?

> +
> +  i2c-atr:
> +    type: object
> +    additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12