Re: [PATCH v15 19/22] arm64: defconfig: disable deprecated MAX96712 driver
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The arm64 defconfig loses support for MAX96712/MAX96724 hardware because the replacement driver (CONFIG_VIDEO_MAX96724) is not enabled. -- --- Patch [19]: [PATCH v15 19/22] arm64: defconfig: disable deprecated MAX96712 driver --- commit 20e07e4ca371980348da7922e6ddc12b0da43b35 Author: Cosmin Tanislav <[email protected]> arm64: defconfig: disable deprecated MAX96712 driver This commit removes the deprecated staging MAX96712 driver from the arm64 defconfig as its functionality has moved to the MAX96724 driver. > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 6ec8d3a69c98e..e0bdfffd9c525 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1420,7 +1420,6 @@ CONFIG_GREYBUS=m > CONFIG_GREYBUS_BEAGLEPLAY=m > CONFIG_STAGING=y > CONFIG_STAGING_MEDIA=y > -CONFIG_VIDEO_MAX96712=m [Severity: Medium] Since the functionality was moved to the MAX96724 driver as noted in the commit message, should CONFIG_VIDEO_MAX96724=m be added here to maintain out-of-the-box hardware support? Without it, the defconfig drops support for this hardware entirely. > CONFIG_VIDEO_MESON_VDEC=m > CONFIG_SND_BCM2835=m > CONFIG_CHROME_PLATFORMS=y -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=19