Re: [PATCH v5 1/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series

"Javier Carrasco" <[email protected]>
Newsgroups org.kernel.vger.linux-devicetree,dev.linux.lists.sashiko-reviews
Message-ID <[email protected]>
On Fri Aug 7, 2026 at 4:06 PM CEST, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The multiline `title` string in the YAML bindings lacks proper indentation on its continuation line, resulting in a fatal YAML syntax error.
> --
>
> --- Patch [1]: [PATCH v5 1/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series ---
> commit 8d68b2e616d3ddf21759545fea44ab122ecc25e0
> Author: Javier Carrasco <[email protected]>
>
> dt-bindings: iio: light: veml6030: add veml6031x00 ALS series
>
> This commit adds the veml6031x00 series of ambient light sensors to the
> vishay,veml6030 bindings, updating the required compatibility strings and
> datasheet references.
>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> index 0041e1db68388..6a387c76df353 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> @@ -4,7 +4,8 @@
>>  $id: http://devicetree.org/schemas/iio/light/vishay,veml6030.yaml#
>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> -title: VEML3235, VEML3328, VEML6030, VEML6035 and VEML7700 Ambient Light Sensors (ALS)
>> +title: VEML3235, VEML3328, VEML6030, VEML6031x00 series, VEML6035
>> +and VEML7700 Ambient Light Sensors (ALS)
>
> [Severity: Low]
> Does this continuation line need to be indented?
>
> Because it lacks indentation relative to the root mapping at column 0, the
> YAML parser treats it as a new implicit block mapping key rather than a
> continuation of the title scalar. This results in a syntax error during
> dt_binding_check.
>
> [ ... ]

This is right, another device was added to the title between versions and
this 2-line title need two white spaces at the beginning of the second
line. I just validated it with dt_binding_check, and it will be added to
V6.

Best regards,
Javier
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.