Re: [PATCH v10 03/10] dt-bindings: bluetooth: qcom: Add NVMEM BD address cell

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing C implementation for Bluetooth NVMEM cell consumption.
--

--- Patch [3]: [PATCH v10 03/10] dt-bindings: bluetooth: qcom: Add NVMEM BD address cell ---
commit fd2db3f3069a2b6bb144aea20efff2a8e20aaf2a
Author: Loic Poulain <[email protected]>
dt-bindings: bluetooth: qcom: Add NVMEM BD address cell

This commit adds support for an NVMEM cell provider for local-bd-address
in the Qualcomm Bluetooth device tree binding. It intends to allow the
Bluetooth stack to retrieve the controller's BD address from non-volatile
storage.

> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml
> --- a/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,bluetooth-common.yaml
[ ... ]
> @@ -22,4 +22,13 @@ properties:
>      description:
>        boot firmware is incorrectly passing the address in big-endian order
>  
> +  nvmem-cells:
> +    maxItems: 1

[Severity: Medium]
Is the C code implementation to read this cell missing from this patch series?

The commit message mentions this allows the Bluetooth stack to retrieve the
controller's BD address from non-volatile storage. However, unlike the
networking stack (which natively resolves mac-address NVMEM cells via
of_get_mac_address_nvmem()), the Bluetooth stack currently only reads the
static local-bd-address firmware node property via
fwnode_property_read_u8_array() in net/bluetooth/hci_sync.c.

Does there need to be a corresponding patch that implements nvmem_cell_get()
for local-bd-address in the Bluetooth core or Qualcomm drivers for this
binding to actually be functional?

> +    description:
> +      Nvmem data cell that contains a 6 byte BD address with the most
> +      significant byte first (big-endian).
> +
> +  nvmem-cell-names:
> +    const: local-bd-address
> +
>  additionalProperties: true

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3