Re: [PATCH 2/2] arm64: dts: rockchip: Add Radxa E54C

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `keyup-threshold-microvolt` property for the ADC keys is erroneously set to `18000` (18 mV) instead of `1800000` (1.8 V), causing the Maskrom button to fail to register presses reliably.
--

--- Patch [2]: [PATCH 2/2] arm64: dts: rockchip: Add Radxa E54C ---
commit 7258a447ec127579f19e2447b1743c6bd29f64a2
Author: Chukun Pan <[email protected]>

arm64: dts: rockchip: Add Radxa E54C

This commit adds device tree support for the Radxa E54C, a network computer
based on the Rockchip RK3582 SoC. It configures the hardware interfaces
including USB, HDMI, ethernet switch, keys, and various regulators.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e54c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e54c.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e54c.dts

[ ... ]

> +	keys-0 {
> +		compatible = "adc-keys";
> +		io-channels = <&saradc 0>;
> +		io-channel-names = "buttons";
> +		keyup-threshold-microvolt = <18000>;

[Severity: Medium]
Is this keyup threshold missing two trailing zeros?

It is currently set to 18000 (18 mV) instead of 1800000 (1.8 V). Because switch
contact resistance and minor ground bounce can easily produce >9 mV when the
Maskrom button is held down, won't the adc-keys driver incorrectly consider
the button released?

> +		poll-interval = <100>;
> +
> +		button-0 {
> +			label = "Maskrom";
> +			linux,code = <KEY_VENDOR>;
> +			press-threshold-microvolt = <0>;
> +		};
> +	};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2