Re: [PATCH net-next v11 10/12] dt-bindings: net: pcs: Document support for Airoha Ethernet PCS

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `minItems` and `maxItems` constraints in `if-then` blocks for `reg` and `reg-names` allow incomplete device tree nodes to silently pass validation.
--

--- Patch [10]: [PATCH net-next v11 10/12] dt-bindings: net: pcs: Document support for Airoha Ethernet PCS ---
commit d59fd3ae8fb2709a26756c96f02e5d3905143b5a
Author: Christian Marangi <[email protected]>

dt-bindings: net: pcs: Document support for Airoha Ethernet PCS

This patch documents support for Airoha Ethernet PCS for AN7581 SoC.
It adds a new physical coding sublayer provider binding for the various
Serdes ports (10BASE-R, USXGMII, 2500BASE-X, 1000BASE-X, SGMII).

> diff --git a/Documentation/devicetree/bindings/net/pcs/airoha,pcs.yaml b/Documentation/devicetree/bindings/net/pcs/airoha,pcs.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/pcs/airoha,pcs.yaml
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - airoha,an7581-pcs-eth
> +              - airoha,an7581-pcs-pon
> +
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: PCS MAC reg
> +            - description: HSGMII AN reg
> +            - description: HSGMII PCS reg
> +            - description: MULTI SGMII reg
> +            - description: USXGMII reg
> +            - description: HSGMII rate adaption reg
> +            - description: PCS Analog register
> +            - description: PCS PMA (Physical Medium Attachment) register

[Severity: Medium]
Should this allOf conditional block for eth/pon also specify minItems: 8 and
maxItems: 8 for the reg and reg-names arrays?

Because the top-level schema defines minItems: 6 and maxItems: 15, defining
an items list here without explicit length constraints means a device tree
providing only 6 registers will silently pass validation for this variant.

[ ... ]
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: airoha,an7581-pcs-pcie
> +
> +    then:
> +      properties:
> +        reg:
> +          items:
> +            - description: PCS MAC 0 reg
> +            - description: HSGMII AN 0 reg
> +            - description: HSGMII PCS 0 reg
> +            - description: MULTI SGMII 0 reg
> +            - description: USXGMII 0 reg
> +            - description: HSGMII rate adaption 0 reg
> +            - description: PCS MAC 1 reg
> +            - description: HSGMII AN 1 reg
> +            - description: HSGMII PCS 1 reg
> +            - description: MULTI SGMII 1 reg
> +            - description: USXGMII 1 reg
> +            - description: HSGMII rate adaption 1 reg
> +            - description: PCS Analog register
> +            - description: PCS PMA (Physical Medium Attachment) 0 register
> +            - description: PCS PMA (Physical Medium Attachment) 1 register

[Severity: Medium]
Similarly, does this pcie allOf conditional block need a minItems: 15
constraint to ensure all required registers are present?

Without minItems constraints on reg and reg-names, any array length between
the top-level 6 and 15 will pass validation, allowing incomplete device tree
nodes to be accepted.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10