Re: [PATCH net-next v11 12/12] net: airoha: add phylink support
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] NET_AIROHA unconditionally selects PCS_AIROHA, which leads to an unmet dependency warning on COMPILE_TEST when ACPI and OF are disabled. -- --- Patch [12]: [PATCH net-next v11 12/12] net: airoha: add phylink support --- commit 60178eed84d4f34367e6ce74cdedc61c17f52abb Author: Christian Marangi <[email protected]> net: airoha: add phylink support This commit adds phylink support for GDM ports in the Airoha ethernet driver, configuring GDM1 for internal interface mode and GDM2/3/4 for external PHY or SFP cage operation via PCS. It also updates ethtool link ksettings to use phylink. > diff --git a/drivers/net/ethernet/airoha/Kconfig b/drivers/net/ethernet/airoha/Kconfig > index 1f6640a15fc94..5c54a07d2a768 100644 > --- a/drivers/net/ethernet/airoha/Kconfig > +++ b/drivers/net/ethernet/airoha/Kconfig > @@ -20,6 +20,8 @@ config NET_AIROHA > depends on NET_DSA || !NET_DSA > select NET_AIROHA_NPU > select PAGE_POOL > + select PCS_AIROHA [Severity: Medium] Does selecting PCS_AIROHA here create an unmet dependency warning under COMPILE_TEST? PCS_AIROHA selects FWNODE_PCS, which depends on ACPI || OF. Since NET_AIROHA unconditionally selects PCS_AIROHA without inheriting the ACPI || OF dependency, can this cause a Kconfig warning and potential build failures when both are disabled? [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12