Re: [PATCH v1 1/5] dt-bindings: sound: qcom,q6dsp-lpass-ports: Rename QAIF clock IDs

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Renaming macro definitions in the dt-bindings header without updating corresponding driver usages breaks the kernel build.
--

--- Patch [1]: [PATCH v1 1/5] dt-bindings: sound: qcom,q6dsp-lpass-ports: Rename QAIF clock IDs ---
commit 24389528fddee532f4b72dd537118240033f4a3e
Author: Prasad Kumpatla <[email protected]>

dt-bindings: sound: qcom,q6dsp-lpass-ports: Rename QAIF clock IDs

The patch renames the LAPSS_CLK_ID_QAIF_* macros to LPASS_CLK_ID_QAIF_*
in the dt-bindings header to fix a spelling typo in the prefix.

Link: https://sashiko.dev/#/patchset/[email protected]

> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> index 2e879a3c09aef..3a99703dbc4a0 100644
> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h

[ ... ]

> -#define LAPSS_CLK_ID_QAIF_IF0_IBIT		71
> -#define LAPSS_CLK_ID_QAIF_IF0_EBIT		72
> -#define LAPSS_CLK_ID_QAIF_IF1_IBIT		73
> -#define LAPSS_CLK_ID_QAIF_IF1_EBIT		74
[ ... ]
> -#define LAPSS_CLK_ID_VA_QAIF_IF0_IBIT	97
> -#define LAPSS_CLK_ID_VA_QAIF_IF0_EBIT	98
> +#define LPASS_CLK_ID_QAIF_IF0_IBIT		71
> +#define LPASS_CLK_ID_QAIF_IF0_EBIT		72
> +#define LPASS_CLK_ID_QAIF_IF1_IBIT		73
> +#define LPASS_CLK_ID_QAIF_IF1_EBIT		74

[Severity: Low]
Does renaming these macros here without updating the dependent driver files
break the build?

Looking at q6prm_clks in sound/soc/qcom/qdsp6/q6prm-clocks.c, it appears
to still reference the old macro names:

sound/soc/qcom/qdsp6/q6prm-clocks.c:q6prm_clks() {
    ...
    Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF0_IBIT),
    Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF0_EBIT),
    ...
}

Because Q6PRM_CLK(id) concatenates Q6PRM_##id, the corresponding target macros
in sound/soc/qcom/qdsp6/q6prm.h also still use the LAPSS spelling:

sound/soc/qcom/qdsp6/q6prm.h:
#define Q6PRM_LAPSS_CLK_ID_QAIF_IF0_IBIT        0x500
#define Q6PRM_LAPSS_CLK_ID_QAIF_IF0_EBIT        0x501

Do these C headers and source files need to be updated in this same commit to
prevent undeclared identifier errors during compilation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1