Re: [PATCH v2] dt-bindings: pwm: Convert TI PWM Subsystem to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added YAML binding example contains child nodes (ECAP, EQEP, and EHRPWM) that omit mandatory properties required by their respective device tree schemas, which will cause `make dt_binding_check` to fail.
--

--- Patch [1]: [PATCH v2] dt-bindings: pwm: Convert TI PWM Subsystem to DT schema ---
commit 6e7740860be9339a28d4f050268b9aad56636a0b
Author: Eduard Bostina <[email protected]>

dt-bindings: pwm: Convert TI PWM Subsystem to DT schema

Convert the Texas Instruments SoC PWM Subsystem bindings to DT schema. 
During the conversion, a 'counter' node was added to the allowed child
nodes list to resolve dtbs_check warnings.

Link: https://lore.kernel.org/all/[email protected]/

> diff --git a/Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.yaml b/Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.yaml
> new file mode 100644
> index 0000000000000..e2b6ae326cb58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.yaml

[ ... ]

> +examples:
> +  - |
> +    pwm@48300000 {
> +        compatible = "ti,am33xx-pwmss";
> +        reg = <0x48300000 0x10>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges = <0x48300100 0x48300100 0x80>,   /* ECAP */
> +                 <0x48300180 0x48300180 0x80>,   /* EQEP */
> +                 <0x48300200 0x48300200 0x80>;   /* EHRPWM */
> +
> +        pwm@48300100 {
> +            compatible = "ti,am3352-ecap";
> +            #pwm-cells = <3>;
> +            reg = <0x48300100 0x80>;
> +        };
> +
> +        counter@48300180 {
> +            compatible = "ti,am3352-eqep";
> +            reg = <0x48300180 0x80>;
> +        };
> +
> +        pwm@48300200 {
> +            compatible = "ti,am3352-ehrpwm";
> +            #pwm-cells = <3>;
> +            reg = <0x48300200 0x80>;
> +        };

[Severity: Low]
Will this example fail dt_binding_check validation?

These child nodes omit properties that are mandatory in their respective device
tree schemas. For instance, the ECAP and EHRPWM nodes are missing clocks and
clock-names, and the EQEP node is missing clocks and interrupts.

Since dt_binding_check cross-validates examples against all existing schemas,
omitting these required properties will likely trigger validation errors.

> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1