Re: [PATCH v3] dt-bindings: pinctrl: Convert TI DA850 pupd to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree schema for pin configuration subnodes fails to require the 'groups' property, allowing functionally empty nodes to silently pass validation.
--

--- Patch [1]: [PATCH v3] dt-bindings: pinctrl: Convert TI DA850 pupd to DT schema ---
commit 559e4d94cd353ab8a1d382bd65a364531394cb80
Author: Eduard Bostina <[email protected]>

dt-bindings: pinctrl: Convert TI DA850 pupd to DT schema

Convert the Texas Instruments DA850/OMAP-L138/AM18x pullup/down
controller bindings to DT schema.

Link to v2: https://lore.kernel.org/all/[email protected]/
Link to v1: https://lore.kernel.org/all/[email protected]/

> diff --git a/Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.yaml b/Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.yaml
> new file mode 100644
> index 0000000000000..21d439e08d4b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.yaml

[ ... ]

> @@ -28,17 +28,17 @@
> +patternProperties:
> +  "-groups$":
> +    type: object
> +    additionalProperties: false
> +    patternProperties:
> +      "^(disable|pull-(up|down))$":
> +        $ref: /schemas/pinctrl/pincfg-node.yaml#
> +        properties:
> +          groups:
> +            $ref: /schemas/types.yaml#/definitions/string-array
> +            description: An array of strings containing the name of a pin group.
> +            items:
> +              pattern: "^cp([0-9]|[1-2][0-9]|3[0-1])$"
> +          bias-disable: true
> +          bias-pull-up: true
> +          bias-pull-down: true
> +        additionalProperties: false

[Severity: Medium]
Should the groups property be explicitly listed as a required property in this
schema block?

Without a required: [ groups ] constraint here, a functionally empty node
could silently pass device tree schema validation. For example, a developer
could define a subnode like:

    pull-up {
        bias-pull-up;
    };

Since the kernel driver ignores nodes without target groups, the target
hardware pins would remain unconfigured at runtime without raising any schema
validation warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1