Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit unintentionally introduces a second, undocumented compatible string `asrock,x470d4u-data64-bmc`.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC ---
commit edbc123921dd78f14b8c4849e14a649077a33ee2
Author: Tan Siewert <[email protected]>
dt-bindings: arm: aspeed: add ASRock X470D4U BMC
This commit documents the compatible string for the ASRock X470D4U BMC board.
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index dd7996960de3e..277c0e03cf488 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -40,6 +40,8 @@ properties:
> - asrock,e3c256d4i-bmc
> - asrock,romed8hm3-bmc
> - asrock,spc621d8hm3-bmc
> + - asrock,x470d4u-bmc
> + - asrock,x470d4u-data64-bmc
[Severity: Low]
Is this second compatible string an accidental inclusion? The commit message
explicitly mentions a singular board addition.
The data64 suffix appears to be an internal convention used elsewhere in this
file exclusively for Facebook hardware with 64MB datastores, such as
facebook,wedge400-data64-bmc. This allows an undocumented string to pass
schema validation even though no such ASRock variant appears to exist.
> - asrock,x570d4u-bmc
> - bytedance,g220a-bmc
> - facebook,cmm-bmc
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.