Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

On Fri, Aug 07, 2026 at 01:28:46PM +0300, Alexander Shiyan wrote:
> Add devicetree binding for the onsemi AR0234 CMOS image sensor.
> 
> Signed-off-by: Alexander Shiyan <[email protected]>
> ---
>  .../bindings/media/i2c/onnn,ar0234.yaml       | 126 ++++++++++++++++++
>  1 file changed, 126 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> new file mode 100644
> index 000000000000..d6db435be9e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> @@ -0,0 +1,126 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/onnn,ar0234.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor AR0234 1/2.6-inch CMOS Digital Image Sensor
> +
> +maintainers:
> +  - Alexander Shiyan <[email protected]>
> +
> +description:
> +  The AR0234 is a 1/2.6-inch CMOS digital image sensor with a pixel
> +  array of 1940x1220 pixels, capable of 1920x1200 resolution at up
> +  to 120 fps. It supports MIPI CSI-2 output with 2 or 4 data lanes,
> +  color raw Bayer (8/10-bit) or monochrome output.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: onnn,ar0234cs
> +      - items:
> +          - enum: ["onnn,ar0234cssc", "onnn,ar0234cssm"]

- enum:
    - onnn,ar0234cssc
    - onnn,ar0234cssm

Please explain somewhere what the differences between the 3 cases are.


> +          - const: onnn,ar0234cs
> +
> +  reg:
> +    description: I2C device address
> +    maxItems: 1
> +
> +  clocks:
> +    description: Reference clock (external clock) input
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: Reset pin, usually active low (if needed)
> +    maxItems: 1
> +
> +  vaa-supply:
> +    description: Analog (2.8V) supply regulator
> +
> +  vdd-supply:
> +    description: Digital Core (1.2V) supply regulator
> +
> +  vddio-supply:
> +    description: I/O (1.8V-2.8V) supply regulator
> +
> +  orientation: true
> +  rotation: true

You need a reference to video-interface-device.yaml if you are going to 
use these.

> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    description: CSI-2 transmitter port
> +    additionalProperties: false

blank line

> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false

blank line

> +        properties:
> +          data-lanes:
> +            description: Number of MIPI CSI-2 data lanes
> +            oneOf:
> +              - items:
> +                  enum: [1, 2]

Is any order allowed? That implies some sort of lane remapping. If 
that's not supported, then see pretty much any other binding for an 
example of what this should look like.

> +                minItems: 2
> +                maxItems: 2
> +              - items:
> +                  enum: [1, 2, 3, 4]
> +                minItems: 4
> +                maxItems: 4