[PATCH RESEND v6 0/5] regulator: Add X-Powers AXP318W PMIC support
Jerome Brunet <[email protected]>
| Newsgroups | org.kernel.vger.linux-devicetree,dev.linux.lists.mfd,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
This is version is being resent to include the new mfd mailing list. This patch series adds support for the X-Powers AXP318W PMIC, which is used recently on new boards with Allwinner SoCs (the A733). The PMIC features 9 DCDC buck converters and 28 LDOs, plus the usual ADC, interrupts, and power key components. A datasheet can be found linked in this Wiki table: https://linux-sunxi.org/AXP_PMICs There was an unclosed topic regarding the handling of LDOs output voltage being limited to input voltage being provided by the supply. Chen-Yu noted the min_dropout_uV would be a good fit for that but the actual minimal dropout value was unknown. I've arbitrarily picked 1uV because it is the minimum the framework supports. Realistically a low dropout regulator is bound to have some dropout. This choice does the trick for now and is certain be less restrictive than what it is in reality. If anyone has problems because the dropout is actually higher * it is arguably an HW design error * it is a good time to let us know what the actual dropout is NOTE: Sashiko has repeatedly complained about PLATFORM_DEVID_AUTO. The line it is commenting on is not where PLATFORM_DEVID_AUTO would go, AFAIU. I already commented on it on v3 [1] but it keeps poping up. PLATFORM_DEVID_AUTO would like go here [2] but: * This is a pre-existing problem, unrelated to this series. * I don't know why it is using NONE to start with and if it changing it may break anything. I don't mind sending a follow-up patch if such change is considered safe. Sashiko is also likely to comment on the interrupt controller in the bindings: no, it is not strictly required. [1]: https://lore.kernel.org/all/[email protected]/#t [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mfd/axp20x.c#n1452 Changes in v6: - Apply wording suggestions from Chen-Yu - Link to v5: https://patch.msgid.link/[email protected] Changes in v5: - Fix shutdown register offset - Re-order patches to put fixes first - Tighten DT regexp around swout - Other points raised by Sashiko on v4 are unrelated to the addition of the AXP318 support and pre-exist the series. They are not addressed ATM. - Link to v4: https://patch.msgid.link/[email protected] Changes in v4: - Capitalize patch 3 title - regulator: add support for workmode and poly-phase. - i2c: fix probe through i2c sysfs - Link to v3: https://patch.msgid.link/[email protected] Changes in v3: - Correct mess up v2 errors regarding ops and ids. - Correctly propagate errors when checking axp318 threshold. - Fix DT binding regex regarding dcdc max ids - Add missing RTCLDO. - Remove axp318 PEK MFD cell: As pointed out by sashiko, the driver name did not match anything in the pek driver. While the device does support some handling of the power button, it does not seem to match the existing driver. Register 0x36 relates to DLDO3, not the power key, as expected by the misc driver. Leave this out for now. - Constify axp313 and axp717 mfd_cells array for consistency. - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Dropped _NUM_VOLTAGES macros - Use min_dropout_uV to limit LDO voltage to supplies - Add bypass mode for EDLO4/5 - Prevent crossing 1.54V threshold for DCDC6/7/8/9 - Link to v1: https://lore.kernel.org/r/[email protected] --- Andre Przywara (3): dt-bindings: mfd: x-powers,axp152: Document AXP318W mfd: axp20x: Add support for AXP318W PMIC regulator: axp20x: add support for the AXP318W Jerome Brunet (2): mfd: axp20x: Constify axp313 and axp717 cells mfd: axp20x-i2c: Fix i2c instantiation .../devicetree/bindings/mfd/x-powers,axp152.yaml | 28 +- drivers/mfd/axp20x-i2c.c | 26 +- drivers/mfd/axp20x-rsb.c | 1 + drivers/mfd/axp20x.c | 86 +++++- drivers/regulator/axp20x-regulator.c | 324 ++++++++++++++++++++- include/linux/mfd/axp20x.h | 136 ++++++++- 6 files changed, 575 insertions(+), 26 deletions(-) --- base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 change-id: 20260710-axp318-regulator-43545ce3261f Best regards, -- Jerome