Re: [PATCH v5 6/6] arm64: dts: qcom: milos-fairphone-fp6: Add NFC

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing pinctrl state for the `wake-gpios` pin (`gpio7`).
--

--- Patch [6]: [PATCH v5 6/6] arm64: dts: qcom: milos-fairphone-fp6: Add NFC ---
commit c9c7cf311411882808cc647f75e1e16f476acbf7
Author: Jorijn van der Graaf <[email protected]>

arm64: dts: qcom: milos-fairphone-fp6: Add NFC

This commit adds the Samsung S3NRN4V NCI NFC controller on i2c1 to the
milos-fairphone-fp6 device tree. It configures the controller's clock, power
supply, and GPIO lines.

> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> index ebdca0e2d2f3a..bdba848275db4 100644
> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
[ ... ]
> @@ -601,9 +601,22 @@ &gcc {
>  };
>  
>  &i2c1 {
>  	status = "okay";
> +
> +	nfc@27 {
> +		compatible = "samsung,s3nrn4v";
> +		reg = <0x27>;
> +
> +		interrupts-extended = <&tlmm 31 IRQ_TYPE_EDGE_RISING>;
> +		en-gpios = <&tlmm 56 GPIO_ACTIVE_HIGH>;
> +		wake-gpios = <&tlmm 7 GPIO_ACTIVE_HIGH>;
> +		clocks = <&rpmhcc RPMH_LN_BB_CLK2>;
> +
> +		pvdd-supply = <&vreg_l20b>;
> +
> +		pinctrl-0 = <&nfc_default>;
> +		pinctrl-names = "default";
> +	};
>  };
[ ... ]
> @@ -825,6 +838,22 @@ &tlmm {
>  			       <13 1>, /* NC */
>  			       <63 2>; /* WLAN UART */
>  
> +	nfc_default: nfc-default-state {
> +		irq-pins {
> +			pins = "gpio31";
> +			function = "gpio";
> +			drive-strength = <2>;
> +			bias-disable;
> +		};
> +
> +		pd-pins {
> +			pins = "gpio56";
> +			function = "gpio";
> +			drive-strength = <2>;
> +			bias-pull-up;
> +		};
> +	};

[Severity: Low]
Should the pad configuration for gpio7 (used for wake-gpios) be included in
this pinctrl state?

The nfc@27 node defines wake-gpios on gpio7, but nfc_default only configures
the drive strength and bias for gpio31 (irq) and gpio56 (pd/en). This leaves
the wake-gpios pad configuration to hardware defaults or the bootloader state.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6