Re: [PATCH] media: dt-bindings: ti,da850-vpif: Convert to dt-schema
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete device tree binding conversion: the old text binding file was not removed. -- --- Patch [1]: [PATCH] media: dt-bindings: ti,da850-vpif: Convert to dt-schema --- commit 74502dfb55363f0cb7f1ff05a7d4febcf64ff608 Author: Bhargav Joshi <[email protected]> media: dt-bindings: ti,da850-vpif: Convert to dt-schema This commit introduces a new YAML device tree schema for the TI DA850/AM18x VPIF, intended to replace the legacy text binding. It also adds a missing power-domains property to the schema. > Convert the Texas Instruments DA850/AM18x Video Port Interface (VPIF) > device tree binding from text format to YAML dt-schema. [Severity: Low] Does this patch miss removing the original text binding file? The commit message indicates a conversion from text format to YAML schema, but the patch only adds the new ti,da850-vpif.yaml file and does not remove Documentation/devicetree/bindings/media/ti,da850-vpif.txt. Should the legacy text file be deleted in this patch to prevent duplicate documentation in the tree? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1