Re: [PATCH] ASoC: dt-bindings: tse850: Convert to DT schema

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused include directive in the DT example.
--

--- Patch [1]: [PATCH] ASoC: dt-bindings: tse850: Convert to DT schema ---
commit fd4229a28be15b03b82f6b00f748cb23a777434c
Author: Bhargav Joshi <[email protected]>

ASoC: dt-bindings: tse850: Convert to DT schema

This commit converts the Axentia TSE-850 audio complex device tree binding 
from a text document to a YAML schema.

> diff --git a/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml
> new file mode 100644
> index 0000000000000..0ab4b697d28ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/axentia,tse850-pcm5142.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/pwm/pwm.h>

[Severity: Low]
This isn't a bug, but is this include directive for pwm.h still needed?

Since the pwm-regulator node from the original text binding was dropped in the
conversion, no properties in the example use PWM macros. Can this include
be removed to avoid unnecessary dead code in the example block?

> +
> +    sound {
> +        compatible = "axentia,tse850-pcm5142";
> +        axentia,cpu-dai = <&ssc0>;
> +        axentia,audio-codec = <&codec>;
> +        axentia,add-gpios = <&pioA 8 GPIO_ACTIVE_LOW>;
> +        axentia,loop1-gpios = <&pioA 10 GPIO_ACTIVE_LOW>;
> +        axentia,loop2-gpios = <&pioA 11 GPIO_ACTIVE_LOW>;
> +        axentia,ana-supply = <&regulator_ana>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1