Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `excitation-current-nanoamp` property incorrectly uses a YAML list for `items`, defining a 1-element tuple constraint instead of a generic array schema, which breaks configurations using dual excitation currents.
--
--- Patch [1]: [PATCH v5 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 ---
commit 1aa9d5f5c579fdf57e652aeb671cbcbcce2eaa69
Author: Kyle Hsieh <[email protected]>
dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04
This commit adds device tree binding documentation for the Texas Instruments
ADS112C04 I2C Analog-to-Digital Converter. It includes properties for
describing the chip's channels, excitation currents, and reference sources.
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
[ ... ]
> +patternProperties:
> + "^channel@[0-9a-b]$":
> + $ref: adc.yaml
> + unevaluatedProperties: false
> + properties:
[ ... ]
> + excitation-channels:
> + maxItems: 2
> + items:
> + maximum: 5
> + description:
> + Additionally to AIN0-AIN3, IDAC1/IDAC2 can also be routed to
> + REFP0 (4) and REFN0 (5).
> +
> + excitation-current-nanoamp:
> + items:
> + - enum: [10000, 50000, 100000, 250000, 500000, 1000000, 1500000]
[Severity: Medium]
Will this correctly allow multiple excitation currents? The hyphen before enum
defines a 1-item tuple constraint instead of a generic schema constraint for
all array elements.
If a device tree configuration specifies two excitation channels and provides
two corresponding excitation currents, won't this schema enforce a maximum of
1 item and erroneously reject the valid configuration during dtbs_check?
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.