Re: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Removing `bootph-all` from the parent PMIC node prevents U-Boot from probing the PMIC and its regulators during early boot. -- --- Patch [1]: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic --- commit 7e0324188396a118a77eb80307cd8f4be050d7cb Author: Anshul Dalal <[email protected]> arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic This commit moves the 'bootph-all' tag from the parent tps65219 PMIC node to all of its regulator sub-nodes. The intent is to ensure the PMIC regulators are available during the boot phase. > diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts > @@ -681,7 +681,6 @@ rtc: rtc@68 { > }; > > tps65219: pmic@30 { > - bootph-all; > compatible = "ti,tps65219"; > reg = <0x30>; [Severity: High] Will removing bootph-all from the parent PMIC node prevent U-Boot from probing the PMIC and its regulators during early boot? During U-Boot's early boot phases, the driver model only binds nodes with properties like bootph-all. If this is removed from the parent tps65219 node, the parent PMIC might be skipped. Because the parent wouldn't be bound, would the driver model fail to scan or bind its child regulator sub-nodes, even though this patch adds bootph-all to them? Additionally, the U-Boot SPL fdtgrep tool strips essential properties (such as reg and compatible) from untagged parent nodes, which could break the I2C bus device attachment entirely. [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1